-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add comments support for deployment.yaml #6339
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this!! I would really like us to move to smaller PRs so if you'd like to open this as an isolated PR I'd review 👍
@cicdw this is now standalone against |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test coverage for yaml_comment
and the consequent output would be nice
If #6343 is merged, I'll add |
This one seems simpler to move forward, we can add the test over there? |
Sure |
For posterity: test added here |
Summary
Opening this as a separate PR for @cicdw evaluation. Essentially allows
deployment.yaml
to have inline help in the form of comments, that are provided asField(..., yaml_comment="my comment")
. For example (see work queue name):Steps Taken to QA Changes
Checklist
This pull request is:
<link to issue>
" in this Pull Request's summary section.<link to issue>
" in this Pull Request's summary section.Happy engineering!