Load flows for deployments in a worker thread

[zanieb]

Summary

If not run in a worker thread, the user's code is executed in an "async" context which means that any methods decorated by sync_compatible will return a coroutine. However, top-level code in a script is always intended to be run in a "sync" context, so the user can never await the coroutines and code that works without a deployment will break while using a deployment.

Steps Taken to QA Changes

Needs QA and unit test

Checklist

This pull request is:

• A documentation / typographical error fix
  • No tests or issue needed
• A short code fix
  • Please reference the related issue by including "closes <link to issue>" in this Pull Request's summary section.
    • If no issue exists, please create a bug report issue
  • Please include tests. One-line fixes without tests will not be accepted unless it's related to the documentation only.
• A new feature implementation
  • Please reference the related issue by including "closes <link to issue>" in this Pull Request's summary section.
    • If no issue exists, please create a feature enhancement issue
  • Please include tests
  • Please make sure that your QA steps are both thorough and easy to reproduce by somebody with limited knowledge of the feature that you are submitting

Happy engineering!

[cicdw]

interesting - very good detective work

[zanieb]

Thanks! Yeah we need to be careful about performing synchronous IO from asynchronous contexts in general, but it's even more important when it could execute code.

It looks like there are not any isolated tests for load_flow_from_flow_run yet. Are those in progress somewhere?