Update deployment flow run retry settings with runtime values #6489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 19, 2022
zanieb
force-pushed
the
fix-deployment-flow-retries
branch
from
21d006a
to
230659f
Compare
zanieb
force-pushed
the
policy-optional
branch
from
9d34eab
to
26b9052
Compare
zanieb
force-pushed
the
fix-deployment-flow-retries
branch
from
230659f
to
d5e6543
Compare
anna-geller
approved these changes
Aug 19, 2022
Retries are configured on ad-hoc flow runs during flow run creation. When flow runs are created for deployments, settings are copied from the deployment to the flow run. However, deployments do not have any concept of flow run orchestration policies yet. Instead of introducing retries to deployments now, we will update the flow run with any discovered orchestration settings at runtime. In the future, the deployment will have the option of overriding these discovered settings.
zanieb
force-pushed
the
fix-deployment-flow-retries
branch
from
d5e6543
to
ebf383d
Compare
cicdw
approved these changes
Aug 21, 2022
darrida
pushed a commit
to darrida-forked/prefect
that referenced
this pull request
Aug 25, 2022
…tHQ#6489) * Update deployment flow run retry settings with runtime values Retries are configured on ad-hoc flow runs during flow run creation. When flow runs are created for deployments, settings are copied from the deployment to the flow run. However, deployments do not have any concept of flow run orchestration policies yet. Instead of introducing retries to deployments now, we will update the flow run with any discovered orchestration settings at runtime. In the future, the deployment will have the option of overriding these discovered settings. * Add test
zanieb
added
fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Retries are configured on ad-hoc flow runs during flow run creation. When flow runs are created for deployments, settings are copied from the deployment to the flow run. However, deployments do not have any concept of flow run orchestration policies yet. Instead of introducing retries to deployments now, we will update the flow run with any discovered orchestration settings at runtime. In the future, the deployment may override these discovered settings by setting values on flow run creation. With the changes in #6488 we should not need to change this code for that behavior to take effect :)
Requires #6486 and #6488
Closes #6485
Checklist
This pull request is:
<link to issue>" in this Pull Request's summary section.<link to issue>" in this Pull Request's summary section.Happy engineering!