Prevent non-UUID slugs from raising errors on the BlockDocuments APIs. #6541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Prefect Cloud, we observed some errors when clients would send requests for `.../block_documents/null`, which should really be handled at the routing layer with 404s when the path UUIDs can't be parsed. Note that this is just correcting the server-side issue, but does not attempt to diagnose the client-side issue at this time. Also, this does not attempt to go through every route in Orion that includes UUIDs in its path.
✅ Deploy Preview for prefect-orion ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
zangell44
reviewed
Aug 24, 2022
zangell44
previously approved these changes
Aug 24, 2022
zangell44
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In Prefect Cloud, we observed some errors when clients would send requests for
.../block_documents/null, which should really be handled at the routing layerwith 404s when the path UUIDs can't be parsed.
Note that this is just correcting the server-side issue, but does not attempt
to diagnose the client-side issue at this time. Also, this does not attempt
to go through every route in Orion that includes UUIDs in its path.
Steps Taken to QA Changes
Additional regression tests added for this symptom, and no other tests were modified.
Checklist
This pull request is:
<link to issue>" in this Pull Request's summary section.<link to issue>" in this Pull Request's summary section.Happy engineering!