Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve issue with python-based deployments having incorrect entrypoints #6554

Merged
merged 1 commit into from
Aug 25, 2022
Merged

Resolve issue with python-based deployments having incorrect entrypoints #6554

merged 1 commit into from
Aug 25, 2022

Conversation

cicdw
Copy link
Member

@cicdw cicdw commented Aug 24, 2022 •
edited
Loading

This PR resolves a critical issue with Deployments defined via Python; specifically, the entrypoint should always be relative to remote_storage.basepath / path and was incorrectly being set as an absolute path on the local machine, resulting in failed deployment runs.

Closes #6482
Closes #6463
Closes #6469

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • This pull request includes tests or only affects documentation.
  • This pull request includes a bug, feature, enhancement, docs, or maintenance label categorizing the change.

@cicdw cicdw added bug Something isn't working component:deployment Related to workflow deployments labels Aug 24, 2022
@cicdw cicdw requested a review from zanieb as a code owner August 24, 2022 23:09
@netlify
Copy link

netlify bot commented Aug 24, 2022 •
edited
Loading

✅ Deploy Preview for prefect-orion ready!

Name Link
🔨 Latest commit a9dbdbc
🔍 Latest deploy log https://app.netlify.com/sites/prefect-orion/deploys/6306afa6a7769700081f60bd
😎 Deploy Preview https://deploy-preview-6554--prefect-orion.netlify.app/api-ref/prefect/deployments
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

abrookins
abrookins approved these changes Aug 24, 2022
View reviewed changes
Copy link
Collaborator

@abrookins abrookins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍 LGTM

anna-geller
anna-geller approved these changes Aug 24, 2022
View reviewed changes
Copy link
Contributor

@anna-geller anna-geller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QAed with s3 + process and ✅

@cicdw cicdw merged commit d8d812d into main Aug 25, 2022
@cicdw cicdw deleted the fix-python-entrypoint-settr branch August 25, 2022 00:23
@zanieb zanieb added fix A fix for a bug in an existing feature and removed bug Something isn't working labels Aug 30, 2022
@bosmak bosmak mentioned this pull request Aug 30, 2022
Closed
@ColeMurray ColeMurray mentioned this pull request Sep 10, 2022
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abrookins abrookins abrookins approved these changes

@anna-geller anna-geller anna-geller approved these changes

@zanieb zanieb Awaiting requested review from zanieb

@bunchesofdonald bunchesofdonald Awaiting requested review from bunchesofdonald

Assignees
No one assigned
Labels
component:deployment Related to workflow deployments fix A fix for a bug in an existing feature
Projects
None yet
Milestone
No milestone
4 participants
@cicdw @abrookins @anna-geller @zanieb