Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revised Docker flow run tutorial #6612

Merged
merged 6 commits into from
Aug 30, 2022
Merged

Revised Docker flow run tutorial #6612

merged 6 commits into from
Aug 30, 2022

Conversation

tpdorsey
Copy link
Contributor

@tpdorsey tpdorsey commented Aug 30, 2022

The Docker tutorial returns to its former glory, including:

  • Creating and using an infrastructure block
  • Editing a deployment in the UI
  • Executing a flow run in a Docker container

Example

Preview

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • This pull request includes tests or only affects documentation.
  • This pull request includes a bug, feature, enhancement, docs, or maintenance label categorizing the change.

@tpdorsey tpdorsey added the docs label Aug 30, 2022
@netlify
Copy link

netlify bot commented Aug 30, 2022

Deploy Preview for prefect-orion ready!

Name Link
🔨 Latest commit 805a474
🔍 Latest deploy log https://app.netlify.com/sites/prefect-orion/deploys/630e51d59ebff400083c95c9
😎 Deploy Preview https://deploy-preview-6612--prefect-orion.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@zanieb
Copy link
Contributor

zanieb commented Aug 30, 2022

Does the link need to be retained as docker-flow-runner?

@tpdorsey
Copy link
Contributor Author

@madkinsz let me test quickly what else is affected by changing the path...

Copy link
Contributor

@discdiver discdiver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good - found a few broken links and a few clarifications on running the agent in the Docker container locally.

docs/tutorials/docker-flow-runner.md Outdated Show resolved Hide resolved
docs/tutorials/docker-flow-runner.md Outdated Show resolved Hide resolved
docs/tutorials/docker-flow-runner.md Outdated Show resolved Hide resolved
docs/tutorials/docker-flow-runner.md Outdated Show resolved Hide resolved
docs/tutorials/docker-flow-runner.md Outdated Show resolved Hide resolved
docs/tutorials/docker-flow-runner.md Outdated Show resolved Hide resolved
docs/tutorials/docker-flow-runner.md Outdated Show resolved Hide resolved
@tpdorsey tpdorsey merged commit e0ace63 into main Aug 30, 2022
@tpdorsey tpdorsey deleted the docs-tuts-docker branch August 30, 2022 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants