Fix issue with github storage running in non-empty directories #6693
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running a deployment within a Docker image that has a non-empty working directory, GitHub storage would fail because
git clone
errors out if the directory is non-empty. This PR adjusts the logic togit clone
into a temporary directory (that will always be empty) and then recursively copy all files over into the present working directory. This code path is the same as if a user had specified a subdirectory of their repository, so a nice side effect is a unified code path.QA'ed live with @discdiver @WillRaphaelson and @khuyentran1401
Checklist
<link to issue>
"fix
,feature
,enhancement
,docs
, ormaintenance
label categorizing the change.