Protected block compatibility #6986
Conversation
✅ Deploy Preview for prefect-orion ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
| response = await client_with_unprotected_block_api.delete( | ||
| f"/block_schemas/{block_schema.id}" | ||
| ) | ||
| assert response.status_code != 403 |
There was a problem hiding this comment.
Should we assert that status code is 204 like the other tests that have a successful deletion?
tests/orion/api/test_block_types.py
Outdated
| response = await client_with_unprotected_block_api.delete( | ||
| f"/block_types/{system_block_type.id}" | ||
| ) | ||
| assert response.status_code != status.HTTP_403_FORBIDDEN |
There was a problem hiding this comment.
Should we assert that status code is 204 like the other tests that have a successful deletion?
tests/orion/api/test_block_types.py
Outdated
| description="Hi there!", | ||
| ).dict(json_compatible=True), | ||
| ) | ||
| assert response.status_code != status.HTTP_403_FORBIDDEN |
There was a problem hiding this comment.
| assert response.status_code != status.HTTP_403_FORBIDDEN | |
| assert response.status_code != status.HTTP_204_NO_CONTENT |
| json_compatible=True | ||
| ), | ||
| ) | ||
| assert response.status_code != 403 |
There was a problem hiding this comment.
| assert response.status_code != 403 | |
| assert response.status_code != 201 |
There was a problem hiding this comment.
Can you use the fastapi.status enums?
There was a problem hiding this comment.
I do think this is mildly out of scope since I didn't want to go and change every assertion in the block schema test suite but I went ahead and did this anyway
There was a problem hiding this comment.
👍 thanks for taking it on anyway. Didn't realize the whole file was out of date.
The addition of protected block types is a breaking API version change. In order to prevent disruption to users we both bump the API version and add a passthrough for older clients.
Closes #6981
Example
Checklist
<link to issue>"fix,feature,enhancement