Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise informative errors if flow runs are deleted while running #7390

Merged
merged 3 commits into from
Nov 1, 2022
Merged

Raise informative errors if flow runs are deleted while running #7390

merged 3 commits into from
Nov 1, 2022

Conversation

anticorrelator
Copy link
Contributor

If a flow run is deleted while its tasks are being orchestrated, we should raise more informative errors.

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • This pull request includes tests or only affects documentation.
  • This pull request includes a label categorizing the change e.g. fix, feature, enhancement

@anticorrelator anticorrelator added the enhancement An improvement of an existing feature label Oct 31, 2022
@netlify
Copy link

netlify bot commented Oct 31, 2022 •
edited
Loading

✅ Deploy Preview for prefect-orion ready!

Name Link
🔨 Latest commit 84742bf
🔍 Latest deploy log https://app.netlify.com/sites/prefect-orion/deploys/636003509f5cc500080200f1
😎 Deploy Preview https://deploy-preview-7390--prefect-orion.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

zangell44
zangell44 approved these changes Nov 1, 2022
View reviewed changes
Copy link
Collaborator

@zangell44 zangell44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anticorrelator anticorrelator merged commit 240c8c4 into main Nov 1, 2022
@anticorrelator anticorrelator deleted the handle-missing-flow-runs branch November 1, 2022 14:44
@zanieb
Copy link
Contributor

zanieb commented Nov 1, 2022

@anticorrelator I feel like there may have been an open issue for this one

@zanieb
Copy link
Contributor

zanieb commented Nov 1, 2022

Nevermind, I was thinking of #5995

@zanieb
Copy link
Contributor

zanieb commented Nov 1, 2022

Can you update the title to reflect the change in UX so it's nice in the changelog?

@anticorrelator anticorrelator changed the title Handle missing flow runs Raise informative errors if flow runs are deleted while running Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zangell44 zangell44 zangell44 approved these changes

@cicdw cicdw Awaiting requested review from cicdw cicdw is a code owner

@zanieb zanieb Awaiting requested review from zanieb

@jakekaplan jakekaplan Awaiting requested review from jakekaplan

Assignees
No one assigned
Labels
enhancement An improvement of an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anticorrelator @zanieb @zangell44