Update docstrings and messages #8496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpdorsey
requested review from
a team,
anticorrelator and
zangell44
as code owners
src/prefect/cli/kubernetes.py
Outdated
| @@ -1,5 +1,5 @@ | |||
| """ | |||
| Command line interface for working with Orion on Kubernetes | |||
| Command line interface for working with Prefect on Kubernetes | |||
There was a problem hiding this comment.
I gave the replacement guidance a look and it doesn't appear to be 100% clear on cases like this. Did we decided that we can use a generic Prefect or should this be Prefect Server?
There was a problem hiding this comment.
Not all of these commands are related to the server, e.g. installing an agent.
zanieb
force-pushed
the
feature/orion-removal
branch
from
2299bbc
to
22a3d4a
Compare
zanieb
force-pushed
the
more-orion-doc-fixups
branch
from
d933eaa
to
ea5e300
Compare
|
@tpdorsey I've rebased this and resolve a bunch of conflicts where I made the same edits :D |
Merged
zanieb
force-pushed
the
more-orion-doc-fixups
branch
from
ea5e300
to
bdc721a
Compare
# Conflicts: # .github/workflows/integration-tests.yaml # src/prefect/blocks/core.py # src/prefect/cli/block.py # src/prefect/cli/kubernetes.py # src/prefect/cli/profile.py # src/prefect/cli/server.py # src/prefect/client/orchestration.py # src/prefect/experimental/workers/base.py # src/prefect/server/database/alembic_commands.py # src/prefect/server/database/configurations.py # src/prefect/server/database/orm_models.py # src/prefect/server/database/query_components.py # src/prefect/server/models/flow_runs.py # src/prefect/server/orchestration/core_policy.py # src/prefect/server/utilities/database.py # src/prefect/settings.py # tests/cli/test_kubernetes_manifest.py # Conflicts: # src/prefect/logging/handlers.py # tests/test_logging.py # Conflicts: # tests/cli/test_profile.py
zanieb
force-pushed
the
more-orion-doc-fixups
branch
from
bdc721a
to
379488b
Compare
zanieb
added a commit
that referenced
this pull request
Feb 13, 2023
Co-authored-by: Michael Adkins <michael@prefect.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove Orion from docstrings, comments, and messages
Example
Checklist
<link to issue>"fix,feature,enhancement