Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix order return checkbox selector #143

Open
wants to merge 1 commit into
base: 2.1.x
Choose a base branch
from

Conversation

SharakPL
Copy link
Contributor

@SharakPL SharakPL commented Mar 20, 2024

Questions Answers
Description? a9c26ce added .js- selectors in few places.
The one for order returns got messed up. It's supposed to be:
#order-return-form table thead input[type=checkbox], .js-order-return-form table thead input[type=checkbox]
#order-return-form table tbody input[type=checkbox], .js-order-return-form table tbody input[type=checkbox]
but instead it became:
#order-return-form, .js-order-return-form table thead input[type=checkbox]
#order-return-form, .js-order-return-form table tbody input[type=checkbox].
This pr simplifies the selectors and the function to check all products for return.
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? -
Sponsor company -
How to test? 1. Have an order with several products in your customer account
2. Start a return process and see if you can check all products at once from the table header

@SharakPL SharakPL requested a review from a team March 20, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready for review
1 participant