Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minimal quantity reset #145

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Conversation

ComonSoft
Copy link

@ComonSoft ComonSoft commented May 28, 2024

Questions Answers
Description Fixes an issue when a product has a minimum quantity by sale, and user enter a value greater than the minimal with 2 or 3 digits in input field, and click outside, the value comes back to minimal
Category FO
Type bug fix
BC breaks no
Deprecations no
Fixed ticket Fixes #36245, Fixes #28531
Sponsor company @ComonSoft
How to test 1. Go to back office, create a product with a minimal quantity for sale by 5 (sample, works with any value) less than 10
2. Go to frontend product page
3. In the quantity field, enter quantity greater than 10 by keyboard
4. Click outside the input (any where except +- arrows)
5. The quantity in the field goes back to 5.

Fixed minimum quantity reset
boherm
boherm previously approved these changes May 28, 2024
@ps-jarvis ps-jarvis added the Waiting for QA Status: Waiting for QA feedback label May 28, 2024
@paulnoelcholot
Copy link

Hello @ComonSoft, Some checks were not successful. Can you check that?

Thanks!

Added missing radix to parseint function
@ComonSoft
Copy link
Author

Hello @ComonSoft, Some checks were not successful. Can you check that?

Thanks!

Done

@boherm boherm removed Waiting for author Waiting for QA Status: Waiting for QA feedback labels Jun 12, 2024
@boherm
Copy link
Member

boherm commented Jun 12, 2024

Hi @ComonSoft!
Sorry, but the ESLint check failed, can you fix it please? 😔

 ESLint compliant
@ComonSoft
Copy link
Author

ESLint

Done

Remove trailing space
@ps-jarvis ps-jarvis added the Waiting for QA Status: Waiting for QA feedback label Jun 21, 2024
Copy link

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @ComonSoft ,

I have the same behavior with and without your PR using PS 8.1.x and PS 9.0x with classic theme.
In both cases, there's no reset of the minimal quantity when I click outside of the quantity input.

Screen.Recording.2024-06-26.at.15.39.01.mov

I think this PR can be closed.
@PrestaShop/product-council what do you think ?

@ComonSoft
Copy link
Author

Hello @ComonSoft ,

I have the same behavior with and without your PR using PS 8.1.x and PS 9.0x with classic theme. In both cases, there's no reset of the minimal quantity when I click outside of the quantity input.
Screen.Recording.2024-06-26.at.15.39.01.mov

Sorry, but the bug is present set the minimal quantity to a value inferior to 10 ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Waiting for PM Waiting for QA Status: Waiting for QA feedback
Projects
Status: Waiting for PM/UX/Dev
Development

Successfully merging this pull request may close these issues.

6 participants