MO: Fix Php Warning: Round() Expects Parameter 2 To Be Long #26
Conversation
| $this->getCacheId('socialsharing_he ader|'. | ||
| (isset($product->id) && $product->id ? (int)$product->id : ''))) | ||
| ) { | ||
| if (!defined('_PS_PRICE_COMPUTE_PRECISION_')) { |
There was a problem hiding this comment.
_PS_PRICE_COMPUTE_PRECISION_ is not defined on PS versions < 1.6.0.11
There was a problem hiding this comment.
... but if shops are updated to 1.6.1.5, this constant is defined so ... we dont need to do a check.
The only - and very good - solution is to update version of PrestaShop in concerned websites, right ?
To be more explicit: why a majority should accept a patch for a few that dont want to upgrade/update their version of PrestaShop ?
There was a problem hiding this comment.
Yep, release early, release often, totally agree! But don't forget that these modules are also pushed to older versions.
I'm afraid we also can't ignore the the devs who are forced to make their modules compatible with older versions :)
This is the first thing I see (with xdebug) whenever I fire up a new instance of the first stable 1.6 version:
Would be worth spilling a few CPU cycles on newer PS versions, right?
There was a problem hiding this comment.
Yes, let's go for it!
👍
firstred
force-pushed
the
fixcomputeprecision
branch
from
1d23ede
to
18f3a72
Compare
firstred
changed the title
firstred
force-pushed
the
fixcomputeprecision
branch
from
18f3a72
to
b806821
Compare
|
Rebased and changed into an atomic commit ( was huge 😮 ) |
|
LGTM, thanks! |
Solves
Php Warning: Round() Expects Parameter 2 To Be Longbecause_PS_PRICE_COMPUTE_PRECISION_isn't defined on all versions of PrestaShop.Defaults to
0if_PS_PRICE_COMPUTE_PRECISION_is not defined.Also converted to PSR-2 + PHPDoc comments