ESLint: Enabled no-dupe-disjunctions rule
#2951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't understand, if it makes linting this slow, how is it not a problem for live linting? Do editors not run it? |
|
Editors do run it. It's not a problem for editors because they only run ESLint on open files. The rule is slow as in: "it takes about 10ms per regex". This time is noticeable when linting all of our 2500 regexes but not when it's only the 10~20 regexes per language definition. |
|
Ah I see. Thanks for the explanation! I'm fine with this. |
|
In that case, I'll merge the fixes and then this rule. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the
regexp/no-dupe-disjunctionsrule. This is the performance-heavy rule I talked about in #2924.The only commit of this PR will be just enabling the rule. This will allow us to see the problems the rule finds. I will add the fixes for these reports in another PR. This allows merging the fixes even if we should decide against this rule.
@LeaVerou @Golmote @mAAdhaTTah