Control group: feedback from challenge configuration #1119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfloxolodeiro
approved these changes
Sep 23, 2022
asanzo
approved these changes
Sep 26, 2022
| test('expectations ids for control group from a challenge with an invalid configuration', function (assert) { | ||
| const challengeWithValidConfiguration = createComponentMock({ | ||
| expectations: { | ||
| alf: true |
Comment on lines
+152
to
+155
| test('expectations ids for control group from a challenge with a mixed configuration', function (assert) { | ||
| assert.propEqual(challengeExpectations.expectationsIdsForControlGroup(challengeMock), decompositionExpectsIdsForControlGroup) | ||
| }) | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #1112
Otra vez, es otro parche muy feo. Tenemos varios problemas: primero que utilizamos los resultados de correr las expectativas para popular el modal. Y después que, si usamos lo que tenemos de la configuración del challenge, no tenemos una forma cómoda de acceder a la información que necesitamos para poder tener las descripciones correspondientes al grupo de control.
Así que seguimos pateando estas cosas para cuando hagamos un rediseño.
De todas maneras, quedo abierto a propuestas.