Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add markdown to expects #1127

Merged
merged 3 commits into from
Oct 4, 2022
Merged

Add markdown to expects #1127

merged 3 commits into from
Oct 4, 2022

Conversation

asanzo
Copy link
Contributor

@asanzo asanzo commented Sep 30, 2022 •
edited
Loading

[EDIT]

La idea es que sea más ameno el diálogo final, agregando estilos y algún emoji. Para eso:

  1. me bajé una fuente de google que se llama NotoEmoji, en versión color (VEINTE MEGAS) y en versión bco y negro (800kb).
  2. agregué markdown a los diálogos finales.

Hay una forma de no agregar 20 megas al proyecto y es hardcodear las imágenes de los emojis.
Deberíamos testear a ver qué tan malo es el rendimiento.

Resultado:

Control group

imagen

Treatment

imagen

@asanzo asanzo changed the base branch from develop to pre-3.20 September 30, 2022 22:46
@asanzo asanzo marked this pull request as ready for review October 3, 2022 20:10
@asanzo asanzo requested a review from a team as a code owner October 3, 2022 20:10
@asanzo asanzo merged commit d3bd3a8 into pre-3.20 Oct 4, 2022
@asanzo asanzo deleted the addMarkdownToExpects branch October 4, 2022 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlopezalvas dlopezalvas dlopezalvas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asanzo @dlopezalvas