1.12.0 #1149
Merged
1.12.0 #1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Subiendo a ember 3.20
Subiendo a ember 3.24
This reverts commit 20c6119.
Error in static analysis + bug
Solution works is calculated
Jshint usa esversion: 11
Modal scroll & height
Contando expectativas que no se usan para el score
Adding RepetirVacio key to MulangParser
Offline icons
Expectation modal se ve bien al achicar
Sacando info de más del static analysis
Agregando composition 9 a ejercicios
Lautarourtiaga
approved these changes
Oct 18, 2022
Comment on lines
+447
to
+457
| try { | ||
| clearValidations() | ||
| this.set('expects', await this.pilasMulang.analyze(Blockly.mainWorkspace, this.challenge)) | ||
| // Order is important. Warnings should be added first. This way, if errors appear, warning bubbles will be painted red. | ||
| if (this.experiments.shouldShowBlocksWarningExpectationFeedback()) this.showBlocksWarningExpectationFeedback() | ||
| this.showBlocksErrorExpectationFeedback() | ||
| Blockly.Events.fireRunCode() | ||
| } catch (e) { | ||
| console.log(e) | ||
| this.set('staticAnalysisError', e.toString()) | ||
| } |
Comment on lines
+2
to
+10
| .goal { | ||
| margin-top: 1em; | ||
| div, div p { | ||
| display: inline; | ||
| color: inherit; | ||
| } | ||
| md-icon[md-font-icon] { | ||
| color: inherit; | ||
| } |
There was a problem hiding this comment.
seguiste viendo utena ?
| export const newExpectation = (types, expect, id, opts = {}) => | ||
| `expectation "${stringify(id, { ...types, ...opts })}": ${expect};` | ||
| `expectation "${btoa(stringify(id, { ...types, ...opts }))}": ${expect};` |
There was a problem hiding this comment.
btoa como beto casella
There was a problem hiding this comment.
claro, es una referencia a el
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.