Usando lastInteraction para mantener la sesion #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asanzo
approved these changes
Apr 6, 2021
PalumboN
approved these changes
Apr 6, 2021
Comment on lines
-19
to
-20
| _get(key) { return JSON.parse(localStorage.getItem(key) || null) }, | ||
| _save(key, data = null) { localStorage.setItem(key, JSON.stringify(data)) }, |
| const currentSessionId = pbAnalytics.getSession().id | ||
| assert.notEqual(firstSessionId, currentSessionId) | ||
| }) | ||
|
|
||
| function getSession() { | ||
| test('Should update lastInteraction after an interaction', function (assert) { | ||
| pbAnalytics.getSession() // Creates session |
There was a problem hiding this comment.
Creo que esto podría estar en el beforeEach, no?
There was a problem hiding this comment.
Sí. Y si agregamos una variable al suite, el beforeEach podría tener algo así como firstSessionId = pbAnalytics.getSession().id // Creates session y creo que podemos sacar esa línea de todos los tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #730