Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nosub goals #535

Merged
merged 1 commit into from
Jan 15, 2021
Merged

Nosub goals #535

merged 1 commit into from
Jan 15, 2021

Conversation

Matafou
Copy link
Contributor

@Matafou Matafou commented Dec 24, 2020

Coq team is considering (coq/coq#13656) changing all messages containing "subgoal[s]" into "goal[s]". This PR should makes PG compatible with this.
Making this change as early as possible so that as much users as possible have a compatible PG when this lands on coq master (if it does, since this change is still discussed).

@Matafou
Copy link
Contributor Author

Matafou commented Jan 15, 2021

Will merge after rebasing this correctly.

Coq team is currently considering changing all messages containing
"subgoal[s]" into "goal[s]". This commit allows for both.

I make this change as early as possible, even if this chage may not
land in coq's master, so that we support this as early as possible.

I don't see how this could break anything but again the earliest the
best.
@Matafou
Copy link
Contributor Author

Matafou commented Jan 15, 2021

@erik @cpitclaudel
For the record if this happens again: test step_wise.el #081_coq-test-regression-show-proof-diffs had failed but succeeded when rerun. My (weak) guess is a timing problem: this test does a proof-shell-wait and then tests the content of coq-response a bit too fast while it was not yet filled, so it ended up checking that the empty string was equal to some pattern (this I could confirm in the log).

@hendriktews
Copy link
Collaborator

For the record if this happens again: test step_wise.el #081_coq-test-regression-show-proof-diffs had failed but succeeded when rerun.

See #538. Please download the log from the failed testrun and attach the relevant part to #538, because after rerun the logs of the failed test are not accessible any more.

@Matafou
Copy link
Contributor Author

Matafou commented Jan 15, 2021

Sorry I don't have the log of the failed testrun. All I can say is that the message said that "" did not match the regexp. Which suggests that when the coq-response buffer was read it was not yet filled with the coq output. But since this output needs to be processed to interpret xml for background coloring, this may explain a small delay?

@hendriktews
Copy link
Collaborator

Sure. I should have written "next time please consider to download the log and ...". The log that I attached last there hat the same test failing with the same empty string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants