enable Tramp support for Emacs 26 or later #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test exhibits a bug in background compilation that became apparent when working on tramp support: Strange things may happen when the user changes the current buffer, because part of the code may then run with an incorrect default-directory. Introduce hooks before and after busy waiting in the cct library.
tramp support is not complete with this patch, but works if used with care. There are a few assertions that quick user interactions can trigger. Automatic background compilation via tramp is very slow, because tramp opens a new connection with all overhead for each asynchronous coqdep and coqc invocation. With this patch, tramp support only works for Emacs version 26 or later, because it uses make-nearby-temp-file. Modifications: - switch to functions that properly deal with remote or magic files - protect sentinels against multiple instances running interleaved, which suddenly happens under tramp - recognize the error when coqdep cannot access a file Fixes ProofGeneral#104 and fixes ProofGeneral#203.
|
FTR:
Merging now would need to warn users about not triggering any tramp feature during background compilation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tramp support is not complete with these patches, but works if used with care. There are a few assertions that quick user interactions can trigger. Automatic background compilation via tramp is very slow, because tramp opens a new connection with all overhead for each asynchronous coqdep and coqc invocation. With these patches, tramp support only works for Emacs version 26 or later, because it uses make-nearby-temp-file.