Fix #597; ProofGeneral cannot step over Fail correctly
#607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bug happened when `Set Ltac Backtrace` is enabled, which has become the default since a few versions. The fix is to prefix the coq-error-message variable with a negative regexp for "message:\n". This PR should be accepted if it does not slow performances too much.
Matafou
force-pushed
the
fix-#597-Fail-backtrace
branch
from
69619bc
to
d37cd1b
Compare
Matafou
force-pushed
the
fix-#597-Fail-backtrace
branch
from
d37cd1b
to
3b765b4
Compare
|
Performance seem OK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug happened when
Set Ltac Backtraceis enabled, which hasbecome the default since a few versions. The fix is to prefix the
coq-error-message variable with a negative regexp for "message:\n".
This PR should be accepted if it does not slow performances too much.