Fix #625 Indentation very slow. #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Had to change the associativity from `left` to `assoc` for token
`"."`. This speeds up things by limiting smie token lookups.
I had to change a few indentation rules to restore the correct
behaviour with the new grammar. I had to:
- use `smie-indent-virtual`
And as side effects:
- fix a wrong tests.
- fix bugs in find-real-start with sequences of "{ subproof" and comments.
Left for another PR: cleaning up dead code in coq-indent.el.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had to change the associativity from
lefttoassocfor token".". This speeds up things by limiting smie token lookups.I had to change a few indentation rules to restore the correct
behaviour with the new grammar. I had to:
smie-indent-virtualAnd as side effects:
Left for another PR: cleaning up dead code in coq-indent.el.