Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: production builds should fail when lint errors are reported #338

Merged
merged 2 commits into from
Jan 13, 2020
+1,398 −801
Merged

fix: production builds should fail when lint errors are reported #338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0048794
fix: production builds should fail when lint errors are reported
Jan 10, 2020
4e944ac
add to PR instructions
terichadbourne Jan 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion DEVELOPING_TUTORIALS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ Ready to get started? Read on!
- [Add your tutorial to `static/tutorials.json`](#add-your-tutorial-to-statictutorialsjson)
- [Add your tutorial to `static/courses.json`](#add-your-tutorial-to-staticcoursesjson)
- [Update routes and import statements in `src/main.js`](#update-routes-and-import-statements-in-srcmainjs)
- [Submit a pull request](#submit-a-pull-request)
- [Troubleshooting](#troubleshooting)
- [Clearing cached data from localStorage](#clearing-cached-data-from-localstorage)
- [Renaming a tutorial after it has been published](#renaming-a-tutorial-after-it-has-been-published)
Expand Down Expand Up @@ -71,9 +72,10 @@ Ready to get started? Read on!

4. Check out the appropriate branch:

If creating a new tutorial, create a new branch before making any changes:
If creating a new tutorial, create a new branch before making any changes, starting with our current website code (the `code` branch):

```sh
> git checkout code
> git checkout -b new-branch-name
```
If proofing a PR for someone else, check out their branch (you'll see its name listed in the PR):
Expand Down Expand Up @@ -596,6 +598,14 @@ the third lesson would display the following above the lesson title:

`Data Structures | Lesson 3 of 4`

### Submit a pull request

Ready to submit your new tutorial for feedback?

Before submitting new content, please make sure to run `npm run lint`, as a pull request will be rejected if there are any linting errors reported. (New to linting? It's the technical equivalent of grammar- and spell-checking, and will flag any programming errors, bugs, or stylistic errors in your code.)

Once you've addressed any linting errors, ensure all of your commits have been pushed to your branch, then [submit a pull request](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request) on GitHub to merge your branch into our default `code` branch. (If [creating a pull request from a fork](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request-from-a-fork), please check the box to allow edits from maintainers.)

## Troubleshooting

### Clearing cached data from localStorage
Expand Down
Loading