Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement automagic KMS server discovery in pykms_Client #51

Closed
Matthew-Beckett opened this issue Dec 23, 2021 · 8 comments
Closed

Implement automagic KMS server discovery in pykms_Client #51

Matthew-Beckett opened this issue Dec 23, 2021 · 8 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Matthew-Beckett
Copy link
Collaborator

SystemRage#121
@simonmicro

This comment has been minimized.

Sign in to view
@simonmicro simonmicro marked this as a duplicate of #45 Dec 23, 2021
@Matthew-Beckett
Copy link
Collaborator Author

This is not a duplicate this is a feature request

@simonmicro simonmicro reopened this Dec 26, 2021
@simonmicro
Copy link

sry

@simonmicro simonmicro added enhancement New feature or request help wanted Extra attention is needed labels Jan 6, 2022
@edgd1er
Copy link

edgd1er commented Apr 13, 2022

From my understanding, the py_client is ran to bootstart the local kms server in order to reach 25 activations.
what would be the usage to query random kms servers ? (well, server would be known after a DNS request srv _vlmcs._tcp)

@simonmicro
Copy link

py_client is ran to bootstart the local kms server in order to reach 25 activations

Nope, just to trigger the database creation for the sqlite webinterface...

what would be the usage to query random kms servers ?

Could you elaborate?

@edgd1er
Copy link

edgd1er commented Apr 13, 2022

py_client is ran to bootstart the local kms server in order to reach 25 activations

Nope, just to trigger the database creation for the sqlite webinterface...

what would be the usage to query random kms servers ?

Could you elaborate?

Automatic KMS discovery is based on _vlmcs._tcp.domain.tld DNS query. Should you have two or more KMS server on your lan, you can't know for sure what will be the DNS answer, hence what would be the KMS used to activate your client.

although, I get the point, If you wish to validate kms discovery the py_kms client, that feature is needed.

@edgd1er
Copy link

edgd1er commented Apr 13, 2022

#66 is a proposition to implement KMS discovery feature.

simonmicro pushed a commit that referenced this issue Apr 22, 2022
@edgd1er
client: add -D to discover KMS server #51
805c234
simonmicro pushed a commit that referenced this issue Apr 22, 2022
@edgd1er
add dnspython to docker image, add doc. #51
ddb99dd
simonmicro pushed a commit that referenced this issue Apr 22, 2022
@edgd1er
client: handle dns exceptions #51
c74a64c
simonmicro pushed a commit that referenced this issue Apr 22, 2022
@edgd1er
client: request #51 add automatic discovery.
248c144 
changes after review.
simonmicro added a commit that referenced this issue Apr 22, 2022
@simonmicro
Merge pull request #66 from edgd1er/dev
7bea3a2 
client: add -D to discover KMS server #51
@Matthew-Beckett
Copy link
Collaborator Author

Closed, feature merged in #66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@edgd1er @Matthew-Beckett @simonmicro