Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HWID randomization by default in pykms_Server.py. (Parity with Dockerfile) #65

Closed
WinkelCode opened this issue Apr 9, 2022 · 2 comments
Closed

HWID randomization by default in pykms_Server.py. (Parity with Dockerfile) #65

WinkelCode opened this issue Apr 9, 2022 · 2 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@WinkelCode
Copy link

WinkelCode commented Apr 9, 2022 •
edited

Related: SystemRage#131

The Dockerfile uses ENV HWID RANDOM, while the script uses some hardcoded value (see linked issue).

Is there a reason to not make them both generate a random HWID?
@WinkelCode WinkelCode changed the title Shouldn't HWID be randomized by default like it is in docker? Shouldn't HWID be randomized by default like it is in the Dockerfiles? Apr 9, 2022
@WinkelCode WinkelCode changed the title Shouldn't HWID be randomized by default like it is in the Dockerfiles? HWID randomization by default in pykms_Server.py. (Parity with Dockerfile) Apr 9, 2022
@simonmicro
Copy link

Historical reasons? I do not think there is any particular reason (anymore)... Feel free to open a PR to change that 😁

@simonmicro simonmicro added documentation Improvements or additions to documentation enhancement New feature or request labels Feb 21, 2023
simonmicro added a commit that referenced this issue May 6, 2023
@simonmicro
Make hardware-id static in Docker #65 -> SystemRage#131 (comment)
143a0a2
simonmicro added a commit that referenced this issue May 6, 2023
@simonmicro
Make hardware-id random in scripts #65
92ec80b
@simonmicro
Copy link

Done!

simonmicro added a commit that referenced this issue May 7, 2023
@simonmicro
Make hardware-id random in scripts #65
3db2dbc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@simonmicro @WinkelCode