Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply patch from hyperboreanwolfgirl for Windows Server 2022 #96

Merged
merged 1 commit into from May 19, 2024

Conversation

Matthew-Beckett
Copy link
Collaborator

This PR applies the patch created by hyperboreanwolfgirl to support Windows Server 2022

https://github.com/hyperboreanwolfgirl/py-kms/commit/4b6a408e4f1680d71524740499f8909ce651f48d.patch

@Matthew-Beckett Matthew-Beckett added enhancement New feature or request fix This fixed a bug - do not forget to mention the correcsponding issue. labels Jun 26, 2023
@Matthew-Beckett Matthew-Beckett self-assigned this Jun 26, 2023
@@ -103,6 +103,10 @@
<Activate KmsItem="7ba0bf23-d0f5-4072-91d9-d55af5a481b6" />
</CsvlkItem>

<CsvlkItem DisplayName="Windows Server 2022" VlmcsdIndex="0" GroupId="206" MinKeyId="551000000" MaxKeyId="570999999" IniFileName="Windows" EPid="06401-00206-566-174993-03-1033-9600.0000-2802018" Id="ef6cfc9f-8c5d-44ac-9aad-de6a2ea0ae03" InvalidWinBuild="[0,1,2]">
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am concerned by the clashing values for GroupId and EPid I have not tested this change and I am unsure on the success of @hyperboreanwolfgirl in their attempt to get this working.

@Matthew-Beckett
Copy link
Collaborator Author

Matthew-Beckett commented Jun 26, 2023

@simonmicro do not merge this yet, I have not tested this.

If someone could try to engage @hyperboreanwolfgirl to find out their success that'd really help.

@xadammr
Copy link

xadammr commented Aug 26, 2023

  • Activation works prior to having updated KmsDataBase.xml
Screenshot 2023-08-27 at 09 48 53

Tested by overloading the KmsDataBase.xml via Docker:

    volumes:
      - /srv/kms/KmsDataBase-9bdc0e4.xml:/home/py-kms/KmsDataBase.xml

Windows Server 2022 now appears in the GUI under Products... But the existing activations do not reflect the SkuID-- it remains showing the GUID.

Perhaps that's a fault with the web interface, but regardless, this doesn't break activation.

@xadammr
Copy link

xadammr commented Aug 27, 2023

New activation works as well, but it's not capturing the correct name the SKU ID field:

Screenshot 2023-08-27 at 13 19 41

@BenPi-Ross
Copy link

BenPi-Ross commented Feb 29, 2024

I've downloaded this version of the "KmsDataBase.xml" (KmsDataBase_mod.xml.txt) a few months ago and I remember modifying it but I don't remember exactly what I modified.

Anyway it works fine on my side with that file :
image

The only relevant difference that I found that isn't in hyperboreanwolfgirl patch is this line :
<WinBuilds>
[...]
<WinBuild BuildNumber="20348" DisplayName="Windows Server 2022" UseForEpid="true" PlatformId="3612" MayBeServer="true" UsesNDR64="true" MinDate="18/08/2021"/>
</WinBuilds>

@simonmicro simonmicro changed the base branch from master to next May 19, 2024 14:30
@simonmicro
Copy link

Idk, I'll just go ahead and merge this one. It seems stale, but in another issue users mentioned, this works.

@simonmicro simonmicro merged commit 9454447 into next May 19, 2024
1 check passed
@simonmicro simonmicro deleted the feature/windows-server-2022-hyperboreanwolfgirl branch May 19, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fix This fixed a bug - do not forget to mention the correcsponding issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants