Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare support for Python 3.8 #1040

Merged
merged 2 commits into from
Oct 17, 2019
Merged

Declare support for Python 3.8 #1040

merged 2 commits into from
Oct 17, 2019

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Oct 15, 2019

Python 3.8.0 was released yesterday, so declare support for it.

Travis CI doesn't yet have 3.8.0 final, but they do have 3.8-dev which currently points to the release candidate, so is pretty close to the 3.8.0 release, and isort is tested against 3.8-dev.

Edit: Travis have just added 3.8! :)

Here's the Travis tracking issue:

AppVeyor will have support in their next images update: appveyor/ci#3142.

@codecov-io
Copy link

Codecov Report

Merging #1040 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1040   +/-   ##
========================================
  Coverage    88.37%   88.37%           
========================================
  Files           17       17           
  Lines         2787     2787           
  Branches       475      475           
========================================
  Hits          2463     2463           
  Misses         231      231           
  Partials        93       93

@timothycrosley
Copy link
Member

This is fantastic! Thank you!

@timothycrosley timothycrosley merged commit 5a1cbfb into PyCQA:develop Oct 17, 2019
@hugovk hugovk deleted the add-3.8 branch October 17, 2019 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants