Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix poetry pip-shims extras dependency #2078

Merged
merged 1 commit into from
Jan 28, 2023
Merged

Fix poetry pip-shims extras dependency #2078

merged 1 commit into from
Jan 28, 2023

Conversation

jooola
Copy link
Contributor

@jooola jooola commented Jan 28, 2023

With poetry-core>=1.5.0, the dependencies in extras must be present in the main dependency group.

Fix #2077

With poetry-core>=1.5.0, the dependencies in extras must be present in the main dependency group.
@jooola jooola changed the title fix: poetry pip-shims extras format fix: poetry pip-shims extras dependency Jan 28, 2023
@jooola jooola changed the title fix: poetry pip-shims extras dependency Fix poetry pip-shims extras dependency Jan 28, 2023
Copy link

@darpham darpham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darpham
Copy link

darpham commented Jan 28, 2023

Alright, who's got the pager?

@mhsmith
Copy link

mhsmith commented Jan 28, 2023

To prevent something like this from happening again, maybe isort's pyproject.toml should pin a specific version of poetry-core.

@codecov
Copy link

codecov bot commented Jan 28, 2023

Codecov Report

Merging #2078 (0d219a6) into main (ae0cc1c) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2078   +/-   ##
=======================================
  Coverage   99.22%   99.22%           
=======================================
  Files          38       38           
  Lines        3091     3091           
  Branches      747      747           
=======================================
  Hits         3067     3067           
  Misses         14       14           
  Partials       10       10           

@timothycrosley timothycrosley merged commit e833931 into PyCQA:main Jan 28, 2023
@jooola jooola deleted the fix_poetry_validation branch January 28, 2023 16:59
hugovk added a commit to hugovk/em-keyboard that referenced this pull request Jan 29, 2023
hugovk added a commit to hugovk/github-tools that referenced this pull request Jan 29, 2023
hugovk added a commit to hugovk/gutenberg-metadata that referenced this pull request Jan 29, 2023
hugovk added a commit to hugovk/hugovk that referenced this pull request Jan 29, 2023
hugovk added a commit to hugovk/lastfm-tools that referenced this pull request Jan 29, 2023
kgrant-rh pushed a commit to RedHatProductSecurity/osidb that referenced this pull request Feb 13, 2023
jalaziz added a commit to jalaziz/django-rest-framework that referenced this pull request Feb 22, 2023
This fixes recent issues with installing isort via pre-commit that was
introduced in recent versions of poetry-core.

See PyCQA/isort#2078
auvipy pushed a commit to encode/django-rest-framework that referenced this pull request Feb 22, 2023
This fixes recent issues with installing isort via pre-commit that was
introduced in recent versions of poetry-core.

See PyCQA/isort#2078
zamberjo pushed a commit to aurestic/oca-addons-repo-template that referenced this pull request Feb 22, 2023
gadomski added a commit to stac-utils/stac-fastapi-pgstac that referenced this pull request Mar 22, 2023
* deps: bump pre-commit dep versions

Needed to pick up PyCQA/isort#2078

* lint: rename some ambiguous variables
markvader added a commit to markvader/ha-rpi_rf that referenced this pull request Apr 3, 2023
an-ky added a commit to an-ky/pytest-testinfra that referenced this pull request May 9, 2023
Running tox results in an error message:

> Configuration is invalid:
>        - [extras.pipfile_deprecated_finder.2] \
>          'pip-shims<=0.3.4' does not match '^[a-zA-Z-_.0-9]+$'

This is caused by additional checks in poetry-core >= 1.5.0 and fixed
fixed by PyCQA/isort#2078
philpep pushed a commit to pytest-dev/pytest-testinfra that referenced this pull request May 19, 2023
Running tox results in an error message:

> Configuration is invalid:
>        - [extras.pipfile_deprecated_finder.2] \
>          'pip-shims<=0.3.4' does not match '^[a-zA-Z-_.0-9]+$'

This is caused by additional checks in poetry-core >= 1.5.0 and fixed
fixed by PyCQA/isort#2078
sherbang added a commit to gozynta/pre-commit-hooks that referenced this pull request Jun 11, 2023
Particularly upgrade isort to fix dependency issue.
PyCQA/isort#2078
hrodmn added a commit to ncx-co/threedep that referenced this pull request Jul 21, 2023
this fixes an error during isort installation
PyCQA/isort#2078
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build from source (e.g. via pre-commit) is broken by new poetry version
4 participants