Fix issue #643: Optimize noqa() with an lru_cache for Python 3.2+. #644
Conversation
pycodestyle.py
Outdated
| try: | ||
| from functools import lru_cache | ||
| except ImportError: | ||
| def lru_cache(maxsize=128): # noqa as it's a fake implementation. |
There was a problem hiding this comment.
What versions of Python are we guarding against here? I think the minimum version we support now is 3.3.
There was a problem hiding this comment.
According to your tox.ini, it's 2.6. If the minimum supported version is really 3.3 now, it should probably be dropped from tox.ini?
There was a problem hiding this comment.
Sorry, I misspoke. The minimum supported Python 3 version is 3.3. I'm not sure if @IanLee1521 wants to continue to support Python 2.6.
There was a problem hiding this comment.
As long as tox.ini tells 2.6 and 2.7, I'll keep this try, it can easily be dropped later with the drop of 2.x support. I bet some other compatibility things will drop too in any way.
pycodestyle.py
Outdated
| in inspect.signature(function).parameters.values() | ||
| if parameter.kind == parameter.POSITIONAL_OR_KEYWORD] | ||
| except ValueError: | ||
| """Catches "No signature found for builtin <built-in method |
There was a problem hiding this comment.
We merged the other code that doesn't rely on scanning the definitions in the module to find checks. Is this still necessary now? You'll need to rebase so I think this is probably unnecessary at this point.
There was a problem hiding this comment.
It's in fact no longer needed since the merge (kina makes me happy ^^). Rebased on master.
Had to catch a "No signature found for builtin <built-in method search of _sre.SRE_Pattern object at 0x...>" in 3.4: In python3.4 the search was not detected as a function, now that it's wrapped in an lru_cache it is, yet it still has no signature (it has in 3.5+).
Fixes #643 for Python 3.2+.
Had to catch a "No signature found for builtin <built-in method
search of _sre.SRE_Pattern object at 0x...>" in 3.4:
In python3.4 the search was not detected as a function, now that it's
wrapped in an lru_cache it is, yet it still has no signature (it has
in 3.5+).