Add check for over-indented blocks #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebased to resolve merge conflicts. |
sigmavirus24
requested changes
Jan 23, 2019
CHANGES.txt
Outdated
| @@ -20,6 +20,7 @@ New checks: | |||
| in Python 3.7. PR #684. | |||
| * Add E252 error for missing whitespace around equal sign in type annotated | |||
| function arguments with defaults values. PR #717. | |||
| * Add E117 error for over-indented code blocks. | |||
There was a problem hiding this comment.
I don't believe this is the right place to add this because 2.4.0 is already released
testsuite/W19.py
Outdated
| or trailing whitespace | ||
|
|
||
| or trailing whitespace |
There was a problem hiding this comment.
I'm pretty sure we wanted to keep those trailing white spaces
In a project with all lines indented 4 spaces, I noticed pycodestyle was not catching code that was accidentally indented two levels (8 spaces). The over indentation was unintended and can be caught during static analysis. Fixes #430
|
Thanks for the review. I've updated the PR with the suggested changes. 🙂 |
sigmavirus24
approved these changes
Jan 25, 2019
|
Hi @jdufresne @sigmavirus24, this change has started causing E117 to be reported for any files containing tabs. My guess is that this change sees them as being 8 spaces and thus being overindented. For now we will simply disable this error, but I think this should be addressed and I'll open a separate issue for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a project with all lines indented 4 spaces, I noticed pycodestyle was not catching code that was accidentally indented two levels (8 spaces). The over indentation was unintended and can be caught during static
analysis.
Fixes #430