Expect lines to be indented 8 places when tabs are used #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asottile
approved these changes
Feb 1, 2019
jdufresne
commented
Feb 1, 2019
| @@ -125,15 +125,15 @@ def test_styleguide(self): | |||
| report = pycodestyle.StyleGuide().check_files([E11]) | |||
| stdout = sys.stdout.getvalue().splitlines() | |||
| self.assertEqual(len(stdout), report.total_errors) | |||
| self.assertEqual(report.total_errors, 20) | |||
| self.assertEqual(report.total_errors, 24) | |||
There was a problem hiding this comment.
The new errors are:
pycodestyle/testsuite/E11.py:41:1: E302 expected 2 blank lines, found 0
pycodestyle/testsuite/E11.py:42:1: E101 indentation contains mixed spaces and tabs
pycodestyle/testsuite/E11.py:42:1: W191 indentation contains tabs
pycodestyle/testsuite/E11.py:42:3: E117 over-indented
|
PEP8 says:
If a tab is used as indentation (my preference), it should be assumed to have a tabwidth of 4 by default. If other codebases are using other tabwidths (8 and 2 are probably the most common alternatives), then it might make more sense to add a config option to allow customizing tabwidth rather than having the default divert that far from PEP8. (Note also the existence of |
This was referenced Sep 21, 2019
Closed
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #836
@sciyoshi Are you able to test if this fixes the issue you reported?