silence non-local-definitions nightly lint #3901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
force-pushed
the
non-local-definitions
branch
from
556399e
to
2e29a14
Compare
LilyFoote
approved these changes
Feb 26, 2024
Icxolu
approved these changes
Feb 26, 2024
|
Ok, hopefully I got this now... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
non_local_definitionslint from RFC 3373 has just landed on nightly and hit us hard.For now let's just add attributes to silence this and unblock nightly, and come up with a FIXME issue to resolve later.
As this is so new there seems to be an open question if it's firing for exactly the right things, probably the consensus is that yes this behaves as expected, we should watch rust-lang/rust#121621 anyway.