Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump py03 #430

Closed
wants to merge 2 commits into from
Closed

Bump py03 #430

wants to merge 2 commits into from

Conversation

alexespencer
Copy link

@alexespencer
Copy link
Author

Looks like a number of changes will be needed, including PyNativeType being behind the py03 feature gil-refs, as well as changes to calls like as_borrowed(). Will try to spend some time researching this (simultaneously new to rust + pyo3) so would appreciate pointers

@bschoenmaeckers
Copy link

Looks like a number of changes will be needed, including PyNativeType being behind the py03 feature gil-refs, as well as changes to calls like as_borrowed(). Will try to spend some time researching this (simultaneously new to rust + pyo3) so would appreciate pointers

Because PyNativeType is not available without the gil-refs feature you should implement all methods for Bound<Self> instead of &Self.

@alexespencer
Copy link
Author

Closing in favour of #431

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexespencer @bschoenmaeckers