Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds network energy balance plots #1285

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

p-glaum
Copy link
Contributor

@p-glaum p-glaum commented Sep 12, 2024

Closes # (if applicable).

Changes proposed in this Pull Request

This PR is still a draft and needs improvement. Only uses statistics functions to create network plots by including scripts from @bobbyxng, @FabianHofmann and me.

Feel free to make improvements/changes to make it even more modular.

Checklist

  • I tested my contribution locally and it works as intended.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in config/config.default.yaml.
  • Changes in configuration options are documented in doc/configtables/*.csv.
  • Sources of newly added data are documented in doc/data_sources.rst.
  • A release note doc/release_notes.rst is added.

TODOS

  • Add all plotting config settings to the plotting.yaml
  • improve scaling parameters
  • automatically take all carriers from balance_map for plotting of maps
  • write collecting rule to plot all maps

@p-glaum p-glaum marked this pull request as draft September 12, 2024 12:52
Copy link
Contributor

@FabianHofmann FabianHofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks nice @p-glaum, what is the status? can I support with something?

@p-glaum
Copy link
Contributor Author

p-glaum commented Sep 19, 2024

this looks nice @p-glaum, what is the status? can I support with something?

status hasn't changed so far 😅 . It was just an initial draft that the code is not lost/forgotten. I think it still needs some cleaning and updating because not all graphs look nice at the moment. I collected some TODOs above.
Currently, I don't have the time to continue on this. @bobbyxng was also working on this, but I think he is currently also busy. So if you want, you can go ahead with the implementation :)

Copy link
Contributor

github-actions bot commented Oct 9, 2024

Validator Report

I am the Validator. Download all artifacts here.
I'll be back and edit this comment for each new commit.

General

Plots comparison
Main branch Feature branch
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Files comparison
Status NRMSE MAE (norm)
prices.csv ⚠️Changed 0.000 0.22
weighted_prices.csv ⚠️Changed 0.403 0.52
market_values.csv ⚠️Changed 0.000 0.07
price_statistics.csv ⚠️Changed 0.000 0.22
metrics.csv ⚠️Changed 0.000 0.09
cfs.csv ⚠️Changed 0.039 0.06
curtailment.csv ⚠️Changed 0.000 0.18
nodal_cfs.csv ⚠️ NaN mismatch
nodal_supply_energy.csv ⚠️ NaN mismatch
nodal_costs.csv ⚠️ NaN mismatch
nodal_capacities.csv ⚠️ NaN mismatch
supply.csv ✅ Almost equal 0.000 0.02
costs.csv ✅ Almost equal 0.001 0.01
capacities.csv ✅ Almost equal 0.000 0.02
supply_energy.csv ✅ Almost equal 0.000 0.02
energy.csv ✅ Almost equal 0.000 0.02

NRMSE: Normalized (combined-min-max) Root Mean Square Error
MAE (norm): Mean Absolute Error on normalized data (min-max)
Status Threshold: MAE (norm) > 0.05 and NRMSE > 0.3

Model Metrics

Benchmarks Image not available Image not available Image not available

Comparing add_modular_map_plots (d3f38e0) with master (5095a74).
Branch is 2 commits ahead and 0 commits behind.
Last updated on 2024-10-09 13:26:48 CEST.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants