Bugfix of solar constraint in post discretization

[toniseibold]

Bugfix

Changes proposed in this Pull Request

When the post discretization is enabled, the function add_solar_potential_constraints is called multiple times.
The first time, the optimal capacity of generators with carrier solar-hsat is zero. However, the second time, the optimal capacity can be greater than zero which would then overly reduce the potential.
Since the p_nom is set in the next planning horizon in the rule add_brownfield switching from p_nom_opt to p_nom is the correct way to formulate the boundary condition.

Checklist

• I tested my contribution locally and it works as intended.
• Code and workflow changes are sufficiently documented.
  not applicable
• Changed dependencies are added to envs/environment.yaml.
  not applicable
• Changes in configuration options are added in config/config.default.yaml.
  not applicable
• Changes in configuration options are documented in doc/configtables/*.csv.
  not applicable
• Sources of newly added data are documented in doc/data_sources.rst.
  not applicable
• A release note doc/release_notes.rst is added.
  not applicable

[github-actions]

Validator Report

I am the Validator. Download all artifacts here.
I'll be back and edit this comment for each new commit.

General

Plots comparison

Main branch	Feature branch

Files comparison

	Status	NRMSE	MAE (norm)
cfs.csv	⚠️Changed	0.052	0.08
price_statistics.csv	⚠️Changed	0.002	0.18
curtailment.csv	⚠️Changed	0.000	0.16
metrics.csv	⚠️Changed	0.000	0.09
weighted_prices.csv	⚠️Changed	0.394	0.37
prices.csv	⚠️Changed	0.000	0.13
market_values.csv	⚠️Changed	0.001	0.10
nodal_capacities.csv	⚠️ NaN mismatch
nodal_supply_energy.csv	⚠️ NaN mismatch
nodal_costs.csv	⚠️ NaN mismatch
nodal_cfs.csv	⚠️ NaN mismatch
costs.csv	✅ Almost equal	0.001	0.01
energy.csv	✅ Almost equal	0.000	0.02
capacities.csv	✅ Almost equal	0.000	0.03
supply.csv	✅ Almost equal	0.000	0.02
supply_energy.csv	✅ Almost equal	0.000	0.02

NRMSE: Normalized (combined-min-max) Root Mean Square Error
MAE (norm): Mean Absolute Error on normalized data (min-max)
Status Threshold: MAE (norm) > 0.05 and NRMSE > 0.3

Model Metrics

Benchmarks

Comparing post_discretization_solar_bc-1 (5f45820) with master (8f1a6b1).
Branch is 1 commits ahead and 0 commits behind.
Last updated on 2024-10-02 16:36:33 CEST.