-
-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: #1805 #1806
fix: #1805 #1806
Conversation
The updated |
Edit: The CI doesn't catch it, but a |
👍 |
bob do something |
@Pycord-Development/maintainers |
are there any updates? |
Haven't had time to look at this yet. If anyone is able to work on it, that would be great. Otherwise it'll get done when I get around to it. |
We discussed this with Ghoul in a help thread and he managed to come up with this very cursed solution... I wouldn't dare myself but perhaps this could be explored if you're desperate. |
yeah...I would not exactly recommend this be implemented...not the best at typing in python so surely someone will come up with something better. |
I'm not too sure about it but I think #2008 might fix it? MissingField = field(default=MISSING)
# ...
name: Maybe[str] = MissingField
aliases: list[str] = field(default_factory=list)
attribute: Maybe[str] = MissingField
annotation: Maybe[Any] = MissingField
default: Maybe[Any] = MissingField
max_args: Maybe[int] = MissingField
override: Maybe[bool] = MissingField
cast_to_dict: Maybe[bool] = False If the |
potentially, yes, have you tested? |
I think it’s time for this to be fixed, I have to copy and paste a fix everything I install or update py-cord in new bots, which is becoming frustrating since I keep getting the original error if I don’t. |
Yeah what now. Is this tested. Is that fixed. |
Basically changing |
@Lulalaby was this ever merged/fixed? |
It was merged... 8 months ago (and subsequently further patched in #2111), and the last release was 10 months ago 😅 |
Was this merged? |
try and see lol |
Yes, this was merged, just without a changelog entry. We can still add one. |
Summary
Fixes the
commands.FlagConverter
bug in the stable release.Fixes #1805
Information
examples, ...).
Checklist
type: ignore
comments were used, a comment is also left explaining why.