Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add more raw events #1880

Merged
merged 21 commits into from
Feb 10, 2023
Merged

feat: add more raw events #1880

merged 21 commits into from
Feb 10, 2023

Conversation

BobDotCom
Copy link
Member

@BobDotCom BobDotCom commented Jan 17, 2023

Summary

This PR is a continuation of #1862

Events Added

  • raw_member_remove
    • documented
  • raw_thread_update
    • documented
  • raw_thread_member_remove
    • documented

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.

@BobDotCom BobDotCom self-assigned this Jan 17, 2023
@BobDotCom BobDotCom mentioned this pull request Jan 17, 2023
8 tasks
@codecov
Copy link

codecov bot commented Jan 17, 2023

Codecov Report

Merging #1880 (73d1324) into master (44ad1a9) will increase coverage by 0.00%.
The diff coverage is 23.25%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1880   +/-   ##
=======================================
  Coverage   33.33%   33.33%           
=======================================
  Files          97       97           
  Lines       18754    18786   +32     
=======================================
+ Hits         6251     6263   +12     
- Misses      12503    12523   +20     
Flag Coverage Δ
macos-latest-3.10 33.32% <23.25%> (?)
macos-latest-3.11 33.32% <23.25%> (?)
macos-latest-3.8 33.33% <23.25%> (?)
macos-latest-3.9 33.33% <23.25%> (?)
ubuntu-latest-3.10 33.32% <23.25%> (-0.01%) ⬇️
ubuntu-latest-3.11 33.32% <23.25%> (-0.01%) ⬇️
ubuntu-latest-3.8 33.33% <23.25%> (-0.01%) ⬇️
ubuntu-latest-3.9 33.33% <23.25%> (-0.01%) ⬇️
windows-latest-3.10 33.32% <23.25%> (?)
windows-latest-3.8 33.33% <23.25%> (?)
windows-latest-3.9 33.33% <23.25%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
discord/flags.py 76.09% <ø> (ø)
discord/state.py 14.70% <0.00%> (-0.13%) ⬇️
discord/raw_models.py 30.28% <45.45%> (+2.18%) ⬆️
discord/player.py 25.32% <0.00%> (+0.32%) ⬆️
discord/sinks/core.py 40.42% <0.00%> (+1.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44ad1a9...73d1324. Read the comment docs.

@BobDotCom BobDotCom marked this pull request as ready for review February 10, 2023 18:26
@BobDotCom BobDotCom requested a review from a team as a code owner February 10, 2023 18:26
@BobDotCom BobDotCom merged commit 4b84447 into master Feb 10, 2023
@BobDotCom BobDotCom deleted the raw-events branch February 10, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants