-
-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Move additional event handler functionality to Client
#1907
Merged
Lulalaby
merged 14 commits into
Pycord-Development:master
from
davidhozic:feat/improve_event_handlers
Feb 23, 2023
Merged
feat: Move additional event handler functionality to Client
#1907
Lulalaby
merged 14 commits into
Pycord-Development:master
from
davidhozic:feat/improve_event_handlers
Feb 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentRPS
previously requested changes
Feb 5, 2023
davidhozic
force-pushed
the
feat/improve_event_handlers
branch
from
February 5, 2023 16:23
dcb9f09
to
3d67cbe
Compare
davidhozic
force-pushed
the
feat/improve_event_handlers
branch
from
February 5, 2023 19:31
3d67cbe
to
d8bb67c
Compare
for more information, see https://pre-commit.ci
davidhozic
changed the title
feat: Add ability to register multiple event handlers with support for custom handler names
feat: Move additional event handler functionality to Feb 5, 2023
Client
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1907 +/- ##
==========================================
- Coverage 33.37% 33.36% -0.02%
==========================================
Files 97 97
Lines 18847 18851 +4
==========================================
- Hits 6290 6289 -1
- Misses 12557 12562 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
for more information, see https://pre-commit.ci
…dhozic/pycord into feat/improve_event_handlers
Lulalaby
changed the title
feat: Move additional event handler functionality to
feat: Move additional event handler functionality to Feb 23, 2023
Client
Client
Lulalaby
requested review from
Dorukyum,
BobDotCom,
VincentRPS and
plun1331
and removed request for
VincentRPS
February 23, 2023 10:04
Lulalaby
approved these changes
Feb 23, 2023
VincentRPS
approved these changes
Feb 23, 2023
NeloBlivion
added a commit
to NeloBlivion/pycord
that referenced
this pull request
Feb 26, 2023
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The pull request introduces changes proposed in #1906 .
It allows the user to register multiple
on_
event handlers inside theClient
objects instead of just inBot
.Also add support to allow
@listen
without()
at the end.Information
examples, ...).
Checklist
type: ignore
comments were used, a comment is also left explaining why.