Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add None support for ClientUser edit #1994

Merged
merged 3 commits into from
Apr 5, 2023
Merged

fix: add None support for ClientUser edit #1994

merged 3 commits into from
Apr 5, 2023

Conversation

ItsRqtl
Copy link
Contributor

@ItsRqtl ItsRqtl commented Mar 31, 2023

Summary

Fixed AttributeError: 'NoneType' object has no attribute 'startswith' in _bytes_to_base64_data when using None to reset avatar.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

Signed-off-by: ItsRqtl <itsrqtl@gmail.com>
@ItsRqtl ItsRqtl requested a review from a team as a code owner March 31, 2023 08:54
@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Merging #1994 (c4e6b75) into master (982c5d8) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1994      +/-   ##
==========================================
- Coverage   33.33%   33.33%   -0.01%     
==========================================
  Files          97       97              
  Lines       18898    18900       +2     
==========================================
  Hits         6300     6300              
- Misses      12598    12600       +2     
Flag Coverage Δ
macos-latest-3.10 33.31% <0.00%> (-0.01%) ⬇️
macos-latest-3.11 33.31% <0.00%> (-0.01%) ⬇️
macos-latest-3.8 33.32% <0.00%> (-0.01%) ⬇️
macos-latest-3.9 33.32% <0.00%> (-0.01%) ⬇️
ubuntu-latest-3.10 33.31% <0.00%> (-0.01%) ⬇️
ubuntu-latest-3.11 33.31% <0.00%> (-0.01%) ⬇️
ubuntu-latest-3.8 33.32% <0.00%> (-0.01%) ⬇️
ubuntu-latest-3.9 33.32% <0.00%> (-0.01%) ⬇️
windows-latest-3.10 33.31% <0.00%> (-0.01%) ⬇️
windows-latest-3.11 33.31% <0.00%> (-0.01%) ⬇️
windows-latest-3.8 33.32% <0.00%> (-0.01%) ⬇️
windows-latest-3.9 33.32% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
discord/user.py 40.65% <0.00%> (-0.46%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 982c5d8...c4e6b75. Read the comment docs.

Copy link
Member

@plun1331 plun1331 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog.

@plun1331 plun1331 added bug Something isn't working status: awaiting review Awaiting review from a maintainer changelog needed labels Mar 31, 2023
@plun1331 plun1331 added this to the v2.5 milestone Mar 31, 2023
Signed-off-by: ItsRqtl <itsrqtl@gmail.com>
@Lulalaby
Copy link
Member

Lulalaby commented Apr 4, 2023

conflicts

Signed-off-by: ItsRqtl <itsrqtl@gmail.com>
@Lulalaby Lulalaby enabled auto-merge (squash) April 5, 2023 00:36
@Lulalaby Lulalaby merged commit e10e880 into Pycord-Development:master Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working status: awaiting review Awaiting review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants