Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): Fix readthedocs build failures #2046

Merged
merged 1 commit into from
May 5, 2023
Merged

fix(docs): Fix readthedocs build failures #2046

merged 1 commit into from
May 5, 2023

Conversation

BobDotCom
Copy link
Member

Summary

This PR fixes build failures with readthedocs due to a new urllib3 release.

References:

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@BobDotCom BobDotCom marked this pull request as ready for review May 5, 2023 18:07
@BobDotCom BobDotCom requested a review from a team as a code owner May 5, 2023 18:07
@pullapprove4 pullapprove4 bot requested review from Lulalaby and WhoIsConch May 5, 2023 18:07
@BobDotCom BobDotCom enabled auto-merge (squash) May 5, 2023 18:07
Lulalaby
Lulalaby approved these changes May 5, 2023
View reviewed changes
Copy link
Member

@Lulalaby Lulalaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a

@BobDotCom BobDotCom merged commit ea3e3db into master May 5, 2023
@Lulalaby Lulalaby deleted the fix-rtfd branch May 5, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lulalaby Lulalaby Lulalaby approved these changes

@WhoIsConch WhoIsConch Awaiting requested review from WhoIsConch

@VincentRPS VincentRPS Awaiting requested review from VincentRPS

@Dorukyum Dorukyum Awaiting requested review from Dorukyum

@Middledot Middledot Awaiting requested review from Middledot

@FrostByte266 FrostByte266 Awaiting requested review from FrostByte266

@CodeWithSwastik CodeWithSwastik Awaiting requested review from CodeWithSwastik

@ChickenDevs ChickenDevs Awaiting requested review from ChickenDevs

@plun1331 plun1331 Awaiting requested review from plun1331

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BobDotCom @Lulalaby