Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new embedded activities #2102

Merged
merged 5 commits into from
Jun 7, 2023
Merged

feat: add new embedded activities #2102

merged 5 commits into from
Jun 7, 2023

Conversation

JustaSqu1d
Copy link
Member

Summary

Adds "new" embedded activities.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@JustaSqu1d JustaSqu1d added priority: low Low Priority status: awaiting review Awaiting review from a maintainer feature Implements a feature python API Reflection Discords API wasn't correctly reflected in the lib labels Jun 7, 2023
Copy link
Member

@plun1331 plun1331 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Merging #2102 (c95b654) into master (d3f6cc8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2102   +/-   ##
=======================================
  Coverage   33.12%   33.13%           
=======================================
  Files          97       97           
  Lines       19137    19139    +2     
=======================================
+ Hits         6340     6342    +2     
  Misses      12797    12797           
Flag Coverage Δ
macos-latest-3.10 33.12% <100.00%> (+<0.01%) ⬆️
macos-latest-3.11 33.12% <100.00%> (+<0.01%) ⬆️
macos-latest-3.8 33.13% <100.00%> (+<0.01%) ⬆️
macos-latest-3.9 33.13% <100.00%> (+<0.01%) ⬆️
ubuntu-latest-3.10 33.12% <100.00%> (+<0.01%) ⬆️
ubuntu-latest-3.11 33.12% <100.00%> (+<0.01%) ⬆️
ubuntu-latest-3.8 33.13% <100.00%> (+<0.01%) ⬆️
ubuntu-latest-3.9 33.13% <100.00%> (+<0.01%) ⬆️
windows-latest-3.10 33.12% <100.00%> (+<0.01%) ⬆️
windows-latest-3.11 33.12% <100.00%> (+<0.01%) ⬆️
windows-latest-3.8 33.13% <100.00%> (+<0.01%) ⬆️
windows-latest-3.9 33.13% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
discord/enums.py 79.96% <100.00%> (+0.07%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3f6cc8...c95b654. Read the comment docs.

@plun1331 plun1331 merged commit d8377f0 into Pycord-Development:master Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Reflection Discords API wasn't correctly reflected in the lib feature Implements a feature priority: low Low Priority status: awaiting review Awaiting review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants