Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Change type of Guild.bitrate_limit to int. #2387

Merged
merged 4 commits into from
Mar 8, 2024

Conversation

yoggys
Copy link
Contributor

@yoggys yoggys commented Mar 8, 2024

Summary

Changed Guild.bitrate_limit to return an int for consistent application flow as it is expected e.g. when creating voice channels.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

Lulalaby
Lulalaby previously approved these changes Mar 8, 2024
@Lulalaby Lulalaby requested review from Dorukyum and JustaSqu1d and removed request for CodeWithSwastik March 8, 2024 00:13
@Lulalaby Lulalaby enabled auto-merge (squash) March 8, 2024 00:13
Signed-off-by: Lala Sabathil <aiko@aitsys.dev>
Lulalaby
Lulalaby previously approved these changes Mar 8, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: plun1331 <plun1331@gmail.com>
@Lulalaby Lulalaby merged commit 9b1c86c into Pycord-Development:master Mar 8, 2024
29 checks passed
@yoggys yoggys deleted the bitrate_limit_type branch March 8, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants