remove pyramid dependency #97
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes, e.g. in a containerised batch emailer, it is desirable to use pyramid_mailer without pulling in pyramid. The dependency exists only so that a few dozen lines of list manipulation functions can be used. This commit copies this code into pyramid_mailer and slightly simplifies it.
|
Tests currently failing due to coverage < 100% |
|
Let me know if this MR is welcome - if so I'll add some tests to restore coverage to 100% |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, e.g. in a containerised batch emailer, it is desirable to
use pyramid_mailer without pulling in pyramid.
The dependency exists only so that a few dozen lines of list manipulation
functions can be used.
This commit copies this code into pyramid_mailer and slightly simplifies it.