Idea comments fix

[brodul]

Currently commenting ideas is broken. If someone wants to comment an idea just new idea is generated. Because when someone submits the comment form, the target idea param is ignored in add_idea view. Resulting the target to be None and making a new idea.

Please see the test commit.

[mcdonc]

This is probably better spelled as "target = request.params.get('target')" (request.params looks in GET first, then POST).

[brodul]

Hmm, there seems to be a problem with request.params:

(Pdb) l
130     @view_config(permission='post', route_name='idea_add',
131                  renderer='templates/idea_add.pt')
132     def idea_add(request):
133         target = request.params.get('target')
134         import pdb; pdb.set_trace()
135  ->     session = DBSession()
136         if target:
137             target = Idea.get_by_id(target, with_joinedload=False)
138             if not target:
139                 return HTTPNotFound()
140             kind = 'comment'
(Pdb) request.params
{}
(Pdb) request.POST
{'form.submitted': u'Shoot', 'title': u'My comment', 'text': u'My comment is cool', 'target': u'1', 'tags': u'abc def, bar'}
(Pdb) request.GET
{}

Any idea why?

[mcdonc]

No. I see this:

> /home/chrism/projects/shootout/shootout/views.py(143)idea_add()
-> session = DBSession()
(Pdb) n
> /home/chrism/projects/shootout/shootout/views.py(144)idea_add()
-> if target:
(Pdb) p target
None
(Pdb) p request.GET
GET([])
(Pdb) p request.POST
MultiDict([('_csrf', u'f76241bcafad6d2e9f70f57e690b910b6dd6bf50'), ('title', u'title'), ('tags', u'tag1, tag2'), ('text', u'hello'), ('target', u'3'), ('form.submitted', u'Shoot')])
(Pdb) p request.params
NestedMultiDict([('_csrf', u'f76241bcafad6d2e9f70f57e690b910b6dd6bf50'), ('title', u'title'), ('tags', u'tag1, tag2'), ('text', u'hello'), ('target', u'3'), ('form.submitted', u'Shoot')])

[domenkozar]

@brodul are you using DummyRequest?

[mcdonc]

I fixed it in the merge.

[brodul]

@iElectric yes I do

[domenkozar]

See 40a435a

[brodul]

Ok, tnx.