Add state-uninstalled #11
Conversation
|
Legend, thanks @onedr0p - seems like you have been reading my mind, or my not-yet-published ToDo list. I shall test this one out, I have a load of VMs with Docker I can try the uninstall on and see what breaks. |
|
Cool, feel free to ask me to change anything or close this and make changes in a new branch if that's easier. |
|
I may take a while to be able to look at this in detail. Looks like some of the Travis-CI builds have broken due to linting errors, are you able to take a look? |
|
I'll be able to take a look tonight at those. |
|
I believe all the lint issues were fixed, running into API Rate limiting errors now. |
1. Now does not remove prerequisite packages, lvm2 was included in these packages (not good when you use LVM2 for real). 2. Added a bit more idempotency to the shell scripts - only delete if it exists. 3. Check that the process isn't running and binaries are gone.
|
Much thanks with the fixes :) |
|
Made some slight alterations @onedr0p - Are you happy with these changes? I've tested them on my VMs. Main change is to remove the steps to uninstall docker prerequisite packages. Main reason for this is that lvm2 is a required package for docker, however it was already installed on my VMs (I was using it) and the uninstall attempted to remove lvm. Oops. |
|
No worries, I didn't know how far we should go with the uninstalling docker and the deps, or even uninstall docker at all. What you have is fine with me. |
state-uninstalled.ymltemplates/k3s-killall.sh.j2from k3s repotemplates/k3s-uninstall.sh.j2from k3s repotasks/teardowndirectory with uninstall k3s and Docker tasks