added kubelet args key #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #12 |
|
Thanks @carpenike - looks like it is covered in terms of how to implement it. I shall test it on my VM cluster. Any chance an example usage can be put in the README.md somewhere?, eg. under a heading "Important note about I may adjust the .travis-ci.yml file for testing this before merging this in, hopefully this evening (GMT+0), I'll add it to this branch. |
|
Yup that makes sense. My particular use case is for integration with a a cloud provider. IE: https://itnext.io/how-to-integrate-k3s-with-the-cloud-controller-36bd5020b8f7 I’ll put something into the readme today. |
|
Balls, I did not mean to do that. |
|
My sincerest apologies @carpenike - I shall recreate this. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I got them all, let me know if I missed any.
Signed-off-by: Ryan Holt ryan@ryanholt.net