Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add permission become check #20

Merged
merged 1 commit into from
May 10, 2020
Merged

add permission become check #20

merged 1 commit into from
May 10, 2020

Conversation

nolte
Copy link
Contributor

@nolte nolte commented May 9, 2020

Hi, at the moment, (Tested with version v1.4.0), its fail to write the /etc/systemd/system/k3s.service file.

can it be happen that here is a additional become check required?
like:

  become: "{{ k3s_become_for_systemd | ternary(true, false, k3s_become_for_all) }}"

@xanmanning xanmanning self-assigned this May 10, 2020
@xanmanning xanmanning self-requested a review May 10, 2020 00:06
@xanmanning xanmanning added the bug Something isn't working label May 10, 2020
xanmanning
xanmanning approved these changes May 10, 2020
View reviewed changes
Copy link
Member

@xanmanning xanmanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @nolte 👍

@xanmanning xanmanning merged commit 9b8cf85 into PyratLabs:master May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xanmanning xanmanning xanmanning approved these changes

Assignees

@xanmanning xanmanning

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nolte @xanmanning