Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement setting multiple k3s_tls_san #55

Merged
merged 2 commits into from
Sep 26, 2020
Merged

Implement setting multiple k3s_tls_san #55

merged 2 commits into from
Sep 26, 2020

Conversation

onedr0p
Copy link
Collaborator

@onedr0p onedr0p commented Sep 24, 2020

According to the docs at https://rancher.com/docs/k3s/latest/en/installation/ha/#3-configure-the-fixed-registration-address we can set multiple TLS sans

This also keeps support for non lists

this can be a list and iterated over in the systemd service
keeps support for non-array values
@xanmanning xanmanning self-requested a review September 26, 2020 16:34
@xanmanning xanmanning self-assigned this Sep 26, 2020
@xanmanning xanmanning added the enhancement New feature or request label Sep 26, 2020
Copy link
Member

@xanmanning xanmanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @onedr0p

@xanmanning xanmanning merged commit 9a15d8e into PyratLabs:master Sep 26, 2020
@onedr0p onedr0p deleted the patch-3 branch September 26, 2020 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants