Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix check nodes ready without flannel #85

Merged
merged 2 commits into from
Jan 23, 2021
Merged

Fix check nodes ready without flannel #85

merged 2 commits into from
Jan 23, 2021

Conversation

Diaoul
Copy link
Contributor

@Diaoul Diaoul commented Jan 21, 2021 •
edited
Loading

Fixes #84

I've simplified the condition:

A is False or (A is True and B is True)
==
A is False or B is True  # since after the or, A is known to be not False (i.e. True)

You may want to keep the old check in addition to that for backward compatibility (if any).

I've tested that on my setup.

@xanmanning xanmanning self-assigned this Jan 22, 2021
@xanmanning xanmanning self-requested a review January 22, 2021 09:56
@xanmanning xanmanning added the bug Something isn't working label Jan 22, 2021
xanmanning
xanmanning approved these changes Jan 23, 2021
View reviewed changes
Copy link
Member

@xanmanning xanmanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, Cheers @Diaoul

@xanmanning xanmanning merged commit 3716774 into PyratLabs:main Jan 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xanmanning xanmanning xanmanning approved these changes

Assignees

@xanmanning xanmanning

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Installation hangs on "Check that all nodes to be ready"
2 participants
@Diaoul @xanmanning