Skip to content

Commit

Permalink
ZMMiniPlayer::keyPressEvent shouldn't call up twice.
Browse files Browse the repository at this point in the history
The parent ZMLivePlayer::keyPressEvent function already calls the
grandparent MythScreenType::keyPressEvent function. There's no need to
directly call it a second time.

This issue was pointed out by the clang-tidy
bugprone-parent-virtual-call check.
  • Loading branch information
linuxdude42 committed Oct 19, 2018
1 parent a2cb1e4 commit 44ac589
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions mythplugins/mythzoneminder/mythzoneminder/zmminiplayer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -146,8 +146,5 @@ bool ZMMiniPlayer::keyPressEvent(QKeyEvent *event)
if (!handled && ZMLivePlayer::keyPressEvent(event))
handled = true;

if (!handled && MythScreenType::keyPressEvent(event))
handled = true;

return handled;
}

0 comments on commit 44ac589

Please sign in to comment.